Add database archiving #1060
Merged
Add database archiving #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, run failing due to legacy package.json version bug |
…into feat/db-delete
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…into feat/db-delete
BenGamma
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Thanks @chrismclarke, yes this approach is better than the current and will help to better handle the deletion/archiving of content 💪
Maybe as we discussed it could be good to have an other issue for further improvements regarding the deletion/archiving of content. Improvements that comes to my mind are :
- Allow to restore a specific version of a document (like the previous version of an how-to, since we keep an history of modifications)
- give the ability to an admin to delete a user/ map pin / content, by adding a delete button to them. This cases happend a lot and are not conviniently handled right now.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
PR Checklist
masterbranch mergedDescription
Deleting documents from the database is not a trivial issue due to the way docs are cached. If a document is deleted from the server there is no way for a user to know it doesn't exist unless they fetch updates for that specific doc on the server (which might happen when opening a howto for example, but not for the full list on first load as this is inefficient - the full docs would need to be retrieved as there is no way to just query the list of ids that exist within firestore)
Currently the database deletes documents by removing the content and simply marking a
deletedfield and updating the timestamp. This is good in that it will prompt all users to receive the update to that document, however there are still 2 problems with this approach:This update adds a new system, whereby deleted docs are moved from their existing collection (solving 2), and populated in an
_archivedcollection with both metadata stubs and full data stored separately (solving 1). An additional query is added for users to receive updates from the collection, and delete their own cached documents accordingly (keeping solution to initial problem). Additional bindings are made for the 3 existing database systems (firestore, firebase realtime and dexie) to process the deletes.Git Issues
Closes #531
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes